You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be cool if we changed this from a bigint to a PriceEth. Goal: make it more self-documenting what this value is.
cappedAwardAmount
Suggest renaming this to cappedAward
It would be cool if we changed this from a bigint to a PriceUsdc. Goal: make it more self-documenting what this value is.
wasQualified
Suggest renaming this to achievedMinBaseRevenueContribution. Goals include: (i) "was..." can be confusing to interpret in relation to time; (ii) I think it's best not to use the word "qualified" here since that might cause confusion as "qualification" requires both achieving the min base revenue contribution AND not being disqualified. But in the relevant layer of logic we're talking about here, am I correct to understand there's no checking if they are disqualified or not?
totalRevenueContributionAmounttotalRevenueContributionbigintto aPriceEth. Goal: make it more self-documenting what this value is.cappedAwardAmountcappedAwardbigintto aPriceUsdc. Goal: make it more self-documenting what this value is.wasQualifiedachievedMinBaseRevenueContribution. Goals include: (i) "was..." can be confusing to interpret in relation to time; (ii) I think it's best not to use the word "qualified" here since that might cause confusion as "qualification" requires both achieving the min base revenue contribution AND not being disqualified. But in the relevant layer of logic we're talking about here, am I correct to understand there's no checking if they are disqualified or not?