Skip to content

ensnode-sdk: Optimize EnsNodeClient's resolveRecords return types #2019

@Y3drk

Description

@Y3drk

Goal

Optimize EnsNodeClient's resolveRecords method so that the values of the addresses record are typed as NormalizedAddress.

Image

Optimization of other return fields would also be welcome (if possible).

Why

  • Requested by @lightwalker-eth here
  • Would enhance DX, as it would allow the removal of typecasting when using the method (ex. here or here)
    • Without the typecasting, our typecheck check throws the following errors (on the examples listed above)
Image

Metadata

Metadata

Assignees

Labels

Type

Projects

Status

No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions