feat(ensnode-sdk): currencies module #1250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move and extend the `currencies` module from ENSIndexer into ENSNode SDK in order to support goals related to the new `registrars` plugin. Related to #1228.
🦋 Changeset detectedLatest commit: 2eade99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lightwalker-eth
approved these changes
Nov 5, 2025
Member
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
@tk-o Looks nice, thank you 👍 Shared some small feedback please take the lead to merge this when ready. Thanks!
| * Serialized representation of {@link Price}. | ||
| */ | ||
| export interface SerializedPrice extends Omit<Price, "amount"> { | ||
| currency: CurrencyId; |
Member
There was a problem hiding this comment.
Can you double check this noting how this interface is defined to extend Price?
Contributor
Author
There was a problem hiding this comment.
Sure, this noting looks good to me. We take all serializable fileds of Price but we omit the non-serializable ones.
Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move and extend the
currenciesmodule from ENSIndexer into ENSNode SDK in order to support goals related to the newregistrarsplugin.Related to #1228.