Conversation
🦋 Changeset detectedLatest commit: 0c68210 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 19 minutes and 14 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (18)
📝 WalkthroughWalkthroughThis changeset removes the Changes
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly Related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR removes the Key changes:
Confidence Score: 5/5Safe to merge — purely a field removal with no logic changes, fully propagated across all 18 affected files. The change is mechanical and internally consistent: interface, schema, builder, UI, OpenAPI spec, docs, and every mock/test fixture are all updated in lock-step. No remaining P0 or P1 findings; the changeset versioning decision was confirmed by the team as intentional. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["ENSIndexer runtime\n(public-config-builder.ts)"] -->|"getEnsIndexerVersion()\ngetPackageVersion('ponder')\ngetPackageVersion('@adraffy/ens-normalize')"| B["validateEnsIndexerVersionInfo()"]
B --> C["EnsIndexerVersionInfo\n{ ponder, ensDb, ensIndexer, ensNormalize }"]
C --> D["EnsIndexerPublicConfig\n/api/config endpoint"]
D --> E["ENSAdmin UI\n(ensnode-info.tsx)"]
D --> F["ENSApi\n(OpenAPI spec)"]
style C fill:#d4edda,stroke:#28a745
Reviews (2): Last reviewed commit: "Update OpenAPI Spec" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Removes the nodejs runtime version field from the EnsIndexerVersionInfo model and updates dependent schema validation, mocks, tests, and user-facing docs/UI to reflect the simplified version info payload.
Changes:
- Drop
nodejsfromEnsIndexerVersionInfoTypeScript types and associated Zod schema. - Update ENSIndexer/ENSApi/ENSDb SDK mocks + unit tests to match the new versionInfo shape.
- Remove Node.js version reporting from ENSIndexer public config generation and ENSAdmin UI/docs examples.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ensnode-sdk/src/ensindexer/config/zod-schemas.ts | Removes nodejs from the version info Zod schema. |
| packages/ensnode-sdk/src/ensindexer/config/zod-schemas.test.ts | Updates schema parsing/error expectations after removing nodejs. |
| packages/ensnode-sdk/src/ensindexer/config/types.ts | Removes nodejs from EnsIndexerVersionInfo interface docs/type. |
| packages/ensnode-sdk/src/ensindexer/config/conversions.test.ts | Updates config conversion fixtures to omit nodejs. |
| packages/ensnode-sdk/src/ensindexer/client.mock.ts | Updates mocked config response payload to omit nodejs. |
| packages/ensnode-sdk/src/ensapi/config/conversions.test.ts | Updates ENSApi config conversion fixtures to omit nodejs. |
| packages/ensnode-sdk/src/ensapi/client.test.ts | Updates ENSApi client test fixture to omit nodejs. |
| packages/ensdb-sdk/src/client/ensdb-client.mock.ts | Updates ENSDb SDK public config mock to omit nodejs. |
| docs/ensnode.io/src/content/docs/docs/usage/api.mdx | Removes nodejs from the /api/config example response. |
| apps/ensindexer/src/lib/version-info.ts | Removes the Node.js version helper (no longer needed). |
| apps/ensindexer/src/lib/public-config-builder/public-config-builder.ts | Stops including Node.js version in generated ENSIndexer public config. |
| apps/ensindexer/src/lib/public-config-builder/public-config-builder.test.ts | Updates tests/mocks for public config builder after removing nodejs. |
| apps/ensindexer/src/lib/ensdb-writer-worker/ensdb-writer-worker.mock.ts | Updates worker mock version info fixture to omit nodejs. |
| apps/ensapi/src/config/config.schema.test.ts | Updates ENSApi config schema test fixture to omit nodejs. |
| apps/ensadmin/src/components/connection/cards/ensnode-info.tsx | Removes Node.js display card item from ENSAdmin connection info UI. |
| apps/ensadmin/src/app/mock/config-api.mock.ts | Updates ENSAdmin mock config API payload to omit nodejs. |
| .changeset/dry-pants-begin.md | Adds a changeset noting removal of the nodejs field. |
Comments suppressed due to low confidence (1)
apps/ensadmin/src/components/connection/cards/ensnode-info.tsx:453
- ENSAdmin’s mock config fixture (
apps/ensadmin/src/app/mock/config-info/data.json) still includesversionInfo.nodejs. Since this UI no longer displays Node.js and the SDK model removed the field, updating the fixture to match the new shape will avoid future confusion (and potential failures if deserialization becomes strict).
<InfoCardItem
label="Ponder"
value={
<p className={cardItemValueStyles}>{ensIndexerPublicConfig.versionInfo.ponder}</p>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tk-o
force-pushed
the
feat/remove-nodejs-version-info
branch
from
759dd05 to
0c68210
Compare
|
@greptile review |
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
@tk-o Looks good 👍 Please take the lead to merge when ready
Lite PR
Tip: Review docs on the ENSNode PR process
Summary
nodejsfield has been removed fromEnsIndexerVersionInfodata model.Why
Testing
/api/config.Notes for Reviewer (Optional)
Pre-Review Checklist (Blocking)