Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis is an automated Changesets release PR bumping all monorepo packages from Confidence Score: 4/5Safe to merge functionally, but the semver violation flagged in a prior review thread remains unresolved and will silently break external consumers on upgrade. A P1 semver violation was identified in the previous review cycle (breaking field renames shipped as minor bumps for 1.x public packages). That issue still exists in this diff. No new P0/P1 findings were discovered; all other changes are routine version-bump bookkeeping. packages/ensnode-sdk/package.json and packages/ensrainbow-sdk/package.json — both ship breaking API changes under a minor version bump. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
CS[Changesets Action] -->|consumes .changeset/*.md| REL[Release PR #1990]
REL -->|bumps 1.10.1 → 1.11.0| PKG1["@ensnode/ensnode-sdk\n⚠ Breaking changes as minor"]
REL -->|bumps 1.10.1 → 1.11.0| PKG2["@ensnode/ensrainbow-sdk\n⚠ Breaking changes as minor"]
REL -->|bumps 1.10.1 → 1.11.0| PKG3["@namehash/ens-referrals\n✅ Additive minor changes"]
REL -->|bumps 1.10.1 → 1.11.0| PKG4["ensadmin\n✅ UI removals / renames"]
REL -->|bumps 1.10.1 → 1.11.0| PKG5["ensapi / ensindexer\n✅ replaceBigInts migration"]
PKG1 -->|depended on by| PKG2
PKG1 -->|depended on by| PKG3
PKG1 -->|depended on by| PKG4
PKG1 -->|depended on by| PKG5
REL -->|on merge| NPM[npm publish all packages]
Reviews (4): Last reviewed commit: "RELEASING: Releasing 23 package(s)" | Re-trigger Greptile |
8c08124 to
951bd5d
Compare
951bd5d to
84e86f5
Compare
| "name": "@ensnode/ensnode-sdk", | ||
| "version": "1.10.1", | ||
| "version": "1.11.0", | ||
| "type": "module", |
There was a problem hiding this comment.
Breaking changes shipped as a minor bump
The CHANGELOG for @ensnode/ensnode-sdk@1.11.0 explicitly marks changes as Breaking — labelSet → clientLabelSet rename and recordsCount removal — yet the bump is minor (1.10.1 → 1.11.0). Both packages are at 1.x.x and publicly published, so semver requires a major bump (2.0.0) for breaking API changes. Consumers relying on the removed or renamed fields will silently break without any version-range signal to warn them.
| "name": "@ensnode/ensrainbow-sdk", | ||
| "version": "1.10.1", | ||
| "version": "1.11.0", | ||
| "type": "module", |
There was a problem hiding this comment.
Breaking changes shipped as a minor bump
Same issue as @ensnode/ensnode-sdk: @ensnode/ensrainbow-sdk@1.11.0 also contains the breaking EnsRainbowPublicConfig changes (versionInfo replacing version: string, serverLabelSet rename, recordsCount removal) yet bumps minor instead of major. This violates semver for a public 1.x.x package and will silently break consumers.
Releases: @ensnode/ensrainbow-sdk@1.11.0 @ensnode/ensnode-sdk@1.11.0 @namehash/ens-referrals@1.11.0 ensadmin@1.11.0 @ensnode/integration-test-env@1.11.0 @docs/ensnode@1.11.0 ensapi@1.11.0 ensindexer@1.11.0 ensrainbow@1.11.0 fallback-ensapi@1.11.0 @ensnode/ensdb-sdk@1.11.0 @ensnode/ensnode-react@1.11.0 @namehash/namehash-ui@1.11.0 @docs/ensrainbow@1.11.0 enssdk@1.11.0 enscli@1.11.0 enskit@1.11.0 ensskills@1.11.0 @ensnode/datasources@1.11.0 @ensnode/ponder-sdk@1.11.0 @ensnode/ponder-subgraph@1.11.0 @ensnode/shared-configs@1.11.0 @ensnode/enskit-react-example@0.0.3 [skip ci]
84e86f5 to
462a433
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@namehash/ens-referrals@1.11.0
Minor Changes
#1986
aa26180Thanks @Goader! - AddBaseReferralProgramEditionConfigas the shared parent ofReferralProgramEditionConfigandBaseReferralProgramEditionSummary.#1986
aa26180Thanks @Goader! - Expose the per-award-model (pie-split,rev-share-cap) Zod schemas via@namehash/ens-referrals/internal.#1986
aa26180Thanks @Goader! - Reject overlapping referral program editions: for a givensubregistryId, no two editions may share any point in time.Patch Changes
0d8a4b4,0d8a4b4,0d64d9e]:@ensnode/ensnode-sdk@1.11.0
Minor Changes
#1988
0d8a4b4Thanks @tk-o! - Breaking: Updated core ENSNode data models.EnsIndexerPublicConfiglabelSetfield toclientLabelSet.EnsRainbowApiClientOptionslabelSetfield toclientLabelSet.EnsRainbowPublicConfigversion: stringfield withversionInfo: EnsRainbowVersionInfo.labelSetfield toserverLabelSet.recordsCountfield fromEnsRainbowPublicConfig.#1988
0d8a4b4Thanks @tk-o! - Introduced a set of "stack info" data models:EnsIndexerStackInfo,EnsNodeStackInfo.#1978
0d64d9eThanks @shrugs! - AddedreplaceBigInts(sourced from@ponder/utils) andtoJsonhelpers to@ensnode/ensnode-sdk.toJsonnow takes an options object ({ pretty?: boolean }) withprettydefaulting tofalse— pass{ pretty: true }for indented output. Migrated all in-repo call sites and dropped the@ponder/utilsdependency fromensapi.Patch Changes
@ensnode/ensrainbow-sdk@1.11.0
Minor Changes
#1988
0d8a4b4Thanks @tk-o! - Breaking: Updated core ENSNode data models.EnsIndexerPublicConfiglabelSetfield toclientLabelSet.EnsRainbowApiClientOptionslabelSetfield toclientLabelSet.EnsRainbowPublicConfigversion: stringfield withversionInfo: EnsRainbowVersionInfo.labelSetfield toserverLabelSet.recordsCountfield fromEnsRainbowPublicConfig.Patch Changes
@ensnode/ensdb-sdk@1.11.0
Patch Changes
0d8a4b4,0d8a4b4,0d64d9e]:enskit@1.11.0
Patch Changes
@ensnode/ensnode-react@1.11.0
Patch Changes
0d8a4b4,0d8a4b4,0d64d9e]:@namehash/namehash-ui@1.11.0
Patch Changes
0d8a4b4,0d8a4b4,0d64d9e]:@ensnode/datasources@1.11.0
enssdk@1.11.0
ensskills@1.11.0
@ensnode/ponder-sdk@1.11.0
@ensnode/ponder-subgraph@1.11.0
ensadmin@1.11.0
Minor Changes
#1988
0d8a4b4Thanks @tk-o! - Removed Records Count info from the ENSRainbow card UI on the Connection page.#1988
0d8a4b4Thanks @tk-o! - RenamedENSNodeConfig*components to follow theEnsNodeStackInfo*pattern.Patch Changes
0d8a4b4,0d8a4b4,0d64d9e]:ensapi@1.11.0
Patch Changes
#1978
0d64d9eThanks @shrugs! - AddedreplaceBigInts(sourced from@ponder/utils) andtoJsonhelpers to@ensnode/ensnode-sdk.toJsonnow takes an options object ({ pretty?: boolean }) withprettydefaulting tofalse— pass{ pretty: true }for indented output. Migrated all in-repo call sites and dropped the@ponder/utilsdependency fromensapi.Updated dependencies [
0d8a4b4,aa26180,0d8a4b4,aa26180,0d64d9e,aa26180]:ensindexer@1.11.0
Patch Changes
#1978
0d64d9eThanks @shrugs! - AddedreplaceBigInts(sourced from@ponder/utils) andtoJsonhelpers to@ensnode/ensnode-sdk.toJsonnow takes an options object ({ pretty?: boolean }) withprettydefaulting tofalse— pass{ pretty: true }for indented output. Migrated all in-repo call sites and dropped the@ponder/utilsdependency fromensapi.Updated dependencies [
0d8a4b4,0d8a4b4,0d64d9e]:ensrainbow@1.11.0
Patch Changes
0d8a4b4,0d8a4b4,0d64d9e]:fallback-ensapi@1.11.0
Patch Changes
0d8a4b4,0d8a4b4,0d64d9e]:@docs/ensnode@1.11.0
Patch Changes
#1965
3facf20Thanks @sevenzing! - Moved docker-compose.yml file to separatedockerdirectory, updates docs and cicd-testsUpdated dependencies []:
@docs/ensrainbow@1.11.0
Patch Changes
@ensnode/enskit-react-example@0.0.3
Patch Changes
@ensnode/integration-test-env@1.11.0
Patch Changes
#1965
3facf20Thanks @sevenzing! - Moved docker-compose.yml file to separatedockerdirectory, updates docs and cicd-testsUpdated dependencies [
0d8a4b4,0d8a4b4,0d64d9e]:enscli@1.11.0
@ensnode/shared-configs@1.11.0