Mark vulnerability as ignored#2030
Conversation
We have addressed it by applyin `uuid@11.1.1`, but OSV Scanner fails to understand that.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
There was a problem hiding this comment.
Pull request overview
Updates OSV Scanner configuration to suppress a specific GHSA finding (GHSA-w5hq-g745-h8pq) that OSV still reports despite the repo using a patched uuid version via pnpm overrides.
Changes:
- Add
GHSA-w5hq-g745-h8pqtoosv-scanner.toml[[IgnoredVulns]]list with an explanatory reason.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greptile SummaryThis PR adds an ignore entry in Confidence Score: 5/5Safe to merge — config-only change that suppresses a confirmed false positive from OSV scanner. The ignore is well-justified: the fix is confirmed backported to uuid v11.1.1 (GitHub releases), the pnpm lockfile only contains uuid@11.1.1, and the pnpm override prevents older vulnerable versions from being installed. No code logic changes are involved. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "Mark vulnerability as ignored" | Re-trigger Greptile |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA new OSV-scanner ignore rule is added for vulnerability Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
Lite PR
Tip: Review docs on the ENSNode PR process
Summary
GHSA-w5hq-g745-h8pqto be ignored by OSV Scanner toolkit.Why
uuid@11.1.1, but OSV Scanner fails to understand that.Testing
Notes for Reviewer (Optional)
v11.1.1release foruuidaddressed the vulnerability in questionPre-Review Checklist (Blocking)