fix: use hashrouter for vercel deployment compat#2040
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe routing configuration in the example application is updated to use React Router's Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
Greptile SummaryReplaces Confidence Score: 5/5Safe to merge — minimal, correct one-file change to an example app. Single import swap in an example app. HashRouter is the standard, zero-config solution for SPA routing on static hosts. No logic, no data, no security surface changed. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Vercel
participant App
Note over User,App: Before (BrowserRouter)
User->>Vercel: GET /domain/eth
Vercel-->>User: 404 (no rewrite rule for SPA routes)
Note over User,App: After (HashRouter)
User->>Vercel: GET /#/domain/eth
Vercel->>App: Serves index.html (root path always matches)
App->>User: React Router reads hash, renders DomainView
Reviews (1): Last reviewed commit: "fix: use hashrouter for vercel deploymen..." | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
Updates the enskit-react-example app’s routing strategy to work on static/Vercel deployments where server-side rewrites for client-side routes aren’t guaranteed.
Changes:
- Replace
BrowserRouterwithHashRouterin the example app to ensure deep links (e.g./domain/...) load correctly on Vercel.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
simple hotfix for the example app