fix: actually hotfix Sepolia BasenamesL1Resolver/LineanamesL1Resolver#2082
fix: actually hotfix Sepolia BasenamesL1Resolver/LineanamesL1Resolver#2082
Conversation
…d changes to the Sepolia Namespace to include Basenames and Lineanames L1 Resolvers.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: fe4d8ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR hotfixes the
Confidence Score: 4/5The change only adds two new contract entries and does not touch any existing configuration, making it safe to merge. The BasenamesL1Resolver address is consistent with existing documentation in the file. The LineanamesL1Resolver address differs from the address cited in the adjacent Lineanames section comment, which is worth a quick author confirmation before the release is widely consumed. packages/datasources/src/sepolia.ts — specifically the LineanamesL1Resolver address Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["ENSRoot (Sepolia)"] --> B["Existing contracts\n(UniversalResolver, NameWrapper, etc.)"]
A --> C["BasenamesL1Resolver\n0x084d10...\nstartBlock: 6501252"]
A --> D["LineanamesL1Resolver\n0xb4b274...\nstartBlock: 10415742"]
C -->|"ResolverABI\nWildcard/CCIP-Read"| E["basetest.eth subnames\n→ Base Sepolia subregistry"]
D -->|"ResolverABI\nWildcard/CCIP-Read"| F["linea-sepolia.eth subnames\n→ Linea Sepolia subregistry"]
style C fill:#d4edda,stroke:#28a745
style D fill:#fff3cd,stroke:#ffc107
Reviews (1): Last reviewed commit: "docs(changeset): Hotfix: re-release of 1..." | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
This PR updates the Sepolia ENS namespace datasource configuration to include the Basenames and Lineanames L1 Resolver contracts, and adds a Changeset to ship the fix as a patch release.
Changes:
- Added
BasenamesL1ResolverandLineanamesL1Resolvercontract configs to the Sepolia ENSRoot datasource. - Added a patch Changeset for
@ensnode/datasourcesdescribing the hotfix release.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/datasources/src/sepolia.ts | Adds Sepolia ENSRoot contract entries for Basenames/Lineanames L1 resolvers. |
| .changeset/true-snakes-return.md | Adds a Changeset to publish the datasource hotfix as a patch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| LineanamesL1Resolver: { | ||
| abi: ResolverABI, | ||
| address: "0xb4b2748f543265e7e0d471f5d1bda81da4e74624", | ||
| startBlock: 10415742, | ||
| }, |
| "@ensnode/datasources": patch | ||
| --- | ||
|
|
||
| Hotfix: re-release of 1.13.0 including the documented changes to the Sepolia Namespace to include Basenames and Lineanames L1 Resolvers. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| LineanamesL1Resolver: { | ||
| abi: ResolverABI, | ||
| address: "0xb4b2748f543265e7e0d471f5d1bda81da4e74624", | ||
| startBlock: 10415742, | ||
| }, |
There was a problem hiding this comment.
The adjacent Lineanames datasource section comment (line 183) states that the resolver for linea-sepolia.eth as of June 2025 is 0x64884ED06241c059497aEdB2C7A44CcaE6bc7937, but the LineanamesL1Resolver being registered here uses 0xb4b2748f543265e7e0d471f5d1bda81da4e74624. If 0xb4b274... is an older/historical contract that was later superseded, the current resolver would not be explicitly indexed. Could you confirm whether 0xb4b274... is correct and, if the two contracts are different, whether the current resolver is already covered by the factory Resolver entry? Can you confirm 0xb4b2748f543265e7e0d471f5d1bda81da4e74624 is the intended LineanamesL1Resolver address on Sepolia, given the Lineanames section documents 0x64884ED06241c059497aEdB2C7A44CcaE6bc7937 as the current resolver for linea-sepolia.eth?
No description provided.