Skip to content

fix bar chart #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djstrong merged 1 commit into from
May 27, 2026
+30 −42
Merged

fix bar chart #2207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 30 additions & 42 deletions docs/ensrainbow.io/src/components/molecules/BarChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,50 +23,38 @@ export default function BarChart({ data, title, subtitle, footnote }: BarChartPr
{subtitle && <p style={{ color: "#666", marginBottom: "1.5rem" }}>{subtitle}</p>}

<div className="w-full flex flex-col gap-4 md:gap-6">
{data.map((item: BarChartData, index: number) => (
<Fragment key={`barChartFragment#${index}`}>
<div key={`barChartFull#${index}`} className="flex flex-col gap-2">
<div
key={`barChartLabel#${index}`}
style={{
display: "flex",
justifyContent: "space-between",
alignItems: "center",
}}
>
{data.map((item: BarChartData, index: number) => {
const percent = (item.value / maxValue) * 100;
const percentLabel = `${index === data.length - 1 ? "+" : ""}${percent}%`;
Comment on lines +27 to +28
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Floating-point percentage label: when item.value is not an exact multiple of maxValue (100), percent will be a float like 33.333333333333336, making the label render as "33.333333333333336%". Consider rounding to a fixed number of decimal places.

Suggested change
const percent = (item.value / maxValue) * 100;
const percentLabel = `${index === data.length - 1 ? "+" : ""}${percent}%`;
const percent = (item.value / maxValue) * 100;
const percentLabel = `${index === data.length - 1 ? "+" : ""}${percent.toFixed(1)}%`;


return (
<Fragment key={`barChartFragment#${index}`}>
<div key={`barChartFull#${index}`} className="flex flex-col gap-2">
<span className="text-sm md:text-base leading-7 font-semibold">{item.label}</span>
<div key={`barChartBar#${index}`} className="flex items-center gap-3">
<div
className="relative h-7 flex-1 min-w-0 rounded-lg overflow-hidden"
style={{ backgroundColor: "#F0F0F0" }}
>
<div
key={`barChartRainbowBar#${index}`}
className="absolute inset-y-0 left-0 rounded-lg transition-[width] duration-500 ease-out"
style={{
width: `${percent}%`,
background: item.color,
backgroundSize: "cover",
}}
/>
</div>
<span className="shrink-0 w-10 text-right text-xs leading-4 font-semibold tabular-nums">
{percentLabel}
</span>
</div>
</div>
<div
key={`barChartBar#${index}`}
style={{
position: "relative",
height: "28px",
backgroundColor: "#F0F0F0",
borderRadius: "8px",
overflow: "hidden",
}}
>
<p className="absolute right-0 top-[calc(50%-8px)] text-xs leading-4 font-semibold px-2">
{index === data.length - 1 && "+"}
{(item.value / maxValue) * 100}%
</p>
<div
key={`barChartRainbowBar#${index}`}
style={{
position: "absolute",
height: "100%",
width: `calc(${(item.value / maxValue) * 100}% - ${index === data.length - 1 ? "30" : "25"}px)`,
background: item.color,
backgroundSize: "cover",
borderRadius: "8px",
transition: "all 500ms ease-out",
}}
/>
</div>
</div>
{index < data.length - 1 && <div className="bg-gray-200 h-px self-stretch" />}
</Fragment>
))}
{index < data.length - 1 && <div className="bg-gray-200 h-px self-stretch" />}
</Fragment>
);
})}
</div>
</div>
{footnote && <p className="text-sm leading-5 font-normal text-gray-500 px-4">{footnote}</p>}
Expand Down
Loading