Skip to content

docs: hosted instance link hover#2208

Closed
notrab wants to merge 7 commits into
fix/docs-inline-code-link-stylingfrom
docs/hosted-instance-link-hover
Closed

docs: hosted instance link hover#2208
notrab wants to merge 7 commits into
fix/docs-inline-code-link-stylingfrom
docs/hosted-instance-link-hover

Conversation

@notrab
Copy link
Copy Markdown
Member

@notrab notrab commented May 27, 2026

Lite PR

Tip: Review docs on the ENSNode PR process

Summary

  • Keep only the underline-offset transition on the "Hosted at" link (drop the hover text color shift)

Why


Testing

  • Checked a few of the regular blue links in docs

Notes for Reviewer (Optional)

spotted this:

image

that we should get rid of, we don't typically have this kind of link with icon.


Pre-Review Checklist (Blocking)

  • This PR does not introduce significant changes and is low-risk to review quickly.
  • Relevant changesets are included (or are not required)

notrab added 2 commits May 27, 2026 17:44
…provider, context, hooks, and query utilities are now exported from `@namehash/namehash-ui`.
Copilot AI review requested due to automatic review settings May 27, 2026 16:58
@notrab notrab requested a review from a team as a code owner May 27, 2026 16:58
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 27, 2026

⚠️ No Changeset found

Latest commit: 9b1748b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
enskit-react-example.ensnode.io Ready Ready Preview, Comment May 27, 2026 6:15pm
ensnode.io Ready Ready Preview, Comment May 27, 2026 6:15pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
admin.ensnode.io Skipped Skipped May 27, 2026 6:15pm
ensrainbow.io Skipped Skipped May 27, 2026 6:15pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Review Change Stack

Warning

Review limit reached

@notrab, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 45 minutes and 15 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5f193874-8f3a-4105-9b6c-5a03be7d7d0a

📥 Commits

Reviewing files that changed from the base of the PR and between d42e0e1 and 9b1748b.

📒 Files selected for processing (5)
  • docs/ensnode.io/src/components/molecules/HostedEnsNodeInstance.astro
  • docs/ensnode.io/src/components/organisms/OmnigraphStaticExampleSet.astro
  • docs/ensnode.io/src/content/docs/docs/integrate/integration-options/enskit/example.mdx
  • docs/ensnode.io/src/content/docs/docs/integrate/integration-options/enssdk/example.mdx
  • docs/ensnode.io/src/styles/starlight.css
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/hosted-instance-link-hover

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the docs site UI for the “Hosted at” URL in the hosted instance card by removing the hover text-color change, aiming to keep the hover interaction limited to underline offset.

Changes:

  • Removed the hover text color shift from the hosted instance URL link.
  • Kept the underline-offset hover interaction and its transition timing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 27, 2026

Greptile Summary

This PR removes hover text-color transitions from documentation links site-wide, keeping only the text-underline-offset animation so hovering a link no longer shifts its color.

  • starlight.css: Adds a blanket .sl-markdown-content a:hover rule locking color to --sl-color-text-accent, removes the previous per-selector --sl-color-accent-high hover overrides for paragraph/list links, and adds a carve-out so heading anchor links still go white on hover.
  • Component/MDX files: Inline Tailwind classes are trimmed to match — hover:text-[...] / group-hover:text-[...] classes are dropped and transition-all is narrowed to transition-[text-underline-offset].

Confidence Score: 5/5

Safe to merge — all changes are scoped to documentation site CSS and component styling with no logic or data-handling code touched.

The diff is entirely CSS class adjustments and a small stylesheet refactor: removing color transitions from hover states and narrowing transition-all to transition-[text-underline-offset]. The new general .sl-markdown-content a:hover rule is correct and the heading-anchor carve-out prevents regressions on anchor links. No logic, API, or build configuration is affected.

No files require special attention.

Important Files Changed

Filename Overview
docs/ensnode.io/src/styles/starlight.css Drops color transitions from markdown links, adds a general hover rule fixing color to --sl-color-text-accent, preserves heading-anchor white hover, cleans up trailing whitespace in comments
docs/ensnode.io/src/components/molecules/HostedEnsNodeInstance.astro Drops hover:text-[...] class and narrows transition to text-underline-offset only, matching the new CSS approach
docs/ensnode.io/src/components/organisms/OmnigraphStaticExampleSet.astro Removes group-hover color class from the back-arrow Icon and narrows transition on the back-link paragraph to text-underline-offset only
docs/ensnode.io/src/content/docs/docs/integrate/integration-options/enskit/example.mdx Removes group-hover color transition from the Icon and the back-link div, narrowing to text-underline-offset transition only
docs/ensnode.io/src/content/docs/docs/integrate/integration-options/enssdk/example.mdx Same pattern as enskit/example.mdx — removes hover color classes and narrows transition to text-underline-offset

Reviews (4): Last reviewed commit: "code suggestion" | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Comment thread docs/ensnode.io/src/styles/starlight.css
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@lightwalker-eth
Copy link
Copy Markdown
Member

@greptile

@notrab notrab changed the base branch from main to fix/docs-inline-code-link-styling May 28, 2026 08:07
@notrab notrab closed this May 28, 2026
notrab added a commit that referenced this pull request May 28, 2026
…ode-link-styling

Brings in PR #2208 component-level hover cleanups (HostedEnsNodeInstance,
OmnigraphStaticExampleSet, enskit/example.mdx, enssdk/example.mdx) and the
broader `a:hover` override in starlight.css.

Conflict in starlight.css resolved by:
- Keeping #2208's broader `.sl-markdown-content a:hover` override.
- Dropping our narrower `> p a` / `li a` hover rule (redundant under #2208's selector).
- Keeping the code-link underline-offset rule from this branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants