fix(docs): round code block frames and remove drop shadow#2246
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates CSS styling for Starlight expressive-code frames in the documentation site, broadening the selector to apply rounded corners and overflow clipping to all frames instead of only non-content frames, and explicitly disables box-shadow. ChangesExpressive Code Frame Styling
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR makes a small cosmetic fix to the documentation site's CSS, improving the appearance of expressive-code blocks by removing an unwanted drop shadow and ensuring rounded corners render correctly.
Confidence Score: 5/5A two-line CSS change scoped entirely to documentation styling — no runtime logic, data, or auth is touched. The change only modifies a single CSS rule in the docs site stylesheet, adding box-shadow: none and broadening the selector to remove a :not(.not-content) guard. Both are intentional cosmetic fixes with no side effects outside the docs UI. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[".sl-markdown-content .expressive-code .frame"] --> B["border-radius: 12px"]
A --> C["overflow: hidden"]
A --> D["box-shadow: none - new"]
A --> E["border-color: color-mix"]
B --> F["Rounded code block corners"]
C --> G["Scrollbar clipped inside rounded shape"]
D --> H["No blurry shadow around frames"]
Reviews (3): Last reviewed commit: "update target" | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
Updates the docs site’s Expressive Code styling so code block containers render with properly rounded corners and without the previously visible square-corner drop shadow bleeding through, improving visual clarity in Starlight’s markdown content area.
Changes:
- Broadens the
.frameselector for Expressive Code blocks so the rounding/overflow rules apply consistently. - Removes the drop shadow on Expressive Code frames to avoid the “blurry box” effect and prevent square shadow corners showing under rounded
<pre>. - Expands the inline CSS comment to explain why the selector must target the figure/frame element.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e68f314 to
e54099b
Compare
|
@Y3drk Starlight adds |
lightwalker-eth
left a comment
There was a problem hiding this comment.
@notrab Thanks, looks nice! 👍
@lightwalker-eth the graphiql code snippets have a shadow which don't look great, but we can update those separately as I remember there was discussion of updating these components. |

Lite PR
Tip: Review docs on the ENSNode PR process
Summary
There was a shadow on expressive code that meant we seen the lack of border radius. The shadow also made the box look blurry.
Before
After
Why
Testing
Notes for Reviewer (Optional)
Pre-Review Checklist (Blocking)