Conversation
Uses reverse registry records to heal label from transaction sender address
…stry-subnames-auto-healing
…stry-subnames-auto-healing
Only the eth plugin uses the env-based feature flag, while other plugins have reverse addresses healing turned off
…stry-subnames-auto-healing
Simplify indexing handlers code and move extra complexity to config file for each plugin.
…stry-subnames-auto-healing
…stry-subnames-auto-healing
…stry-subnames-auto-healing
Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com>
…hub.com:namehash/ensnode into feat/204-reverse-registry-subnames-auto-healing
`Registrar.ts` is only for the registrars for direct subnames of .eth, linea.eth, or base.eth. It can never be a reverse registrar.
Returns `null` if healing fails. Also, all relevant tests were simplified.
…stry-subnames-auto-healing
…stry-subnames-auto-healing
Co-authored-by: kwrobel.eth <djstrong@gmail.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lightwalker-eth
requested changes
Apr 10, 2025
Member
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
@shrugs Huge updates and improvements here! Very happy! 🚀 Reviewed and shared some suggestions. Appreciate your advice. Thanks 🙌
| import * as lineaEthPlugin from "@/plugins/linea/ponder.plugin"; | ||
| import * as basenamesPlugin from "@/plugins/basenames/basenames.plugin"; | ||
| import * as lineaNamesPlugin from "@/plugins/lineanames/lineanames.plugin"; | ||
| import * as rootPlugin from "@/plugins/root/root.plugin"; |
Member
There was a problem hiding this comment.
Depending on your thoughts on the other comment suggesting to rename this to the "subgraph" plugin, there would be some other items to rename, including various files / directories. Advice appreciated.
lightwalker-eth
approved these changes
Apr 14, 2025
Member
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
@shrugs Super updates 🚀 Thank you! Shared a few more little suggestions. Please merge when ready! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #138, closes #87, closes #86, closes #491, closes #115
OwnedNamein favor ofRegistrarManagedNamefor plugins that use the shared handlersOwnedNameresponsibilities intoPluginNameandEventIdPrefixNode,LabelHash,Label,Name)eth = root,base = basenames,linea = lineanames)