optimized bulk inspect names

[djstrong]

No description provided.

[shortcut-integration]

This pull request has been linked to Shortcut Story #22889: Optimize bulk inspect names.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nameguard-website	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 25, 2023 1:07pm

[djstrong]

@lightwalker-eth @Carbon225 Please review the regex and fields in the report - is it always true for any name matching the regex?
TODO: Now I see that Punycode and NameWrapper checks can fail for too long name.

[djstrong]

For Puny and NameWrapper each label's length must be <= 253 and <=255. The simplest solution is:

Suggested change

	SIMPLE_NAME_REGEX = re.compile(r'^[a-z0-9]+\.eth$')
	def simple_name(name: str) -> bool:
	return SIMPLE_NAME_REGEX.match(name) is not None
	def consolidated_report_from_simple_name(name: str) -> ConsolidatedNameGuardReport:
	return ConsolidatedNameGuardReport(
	name=name,
	namehash=namehash_from_name(name),
	normalization=Normalization.NORMALIZED,
	rating=Rating.PASS,
	risk_count=0,
	highest_risk=None,
	)
	SIMPLE_NAME_REGEX = re.compile(r'^[a-z0-9]{1,253}\.eth$')
	def simple_name(name: str) -> bool:
	return SIMPLE_NAME_REGEX.match(name) is not None
	def consolidated_report_from_simple_name(name: str) -> ConsolidatedNameGuardReport:
	return ConsolidatedNameGuardReport(
	name=name,
	namehash=namehash_from_name(name),
	normalization=Normalization.NORMALIZED,
	rating=Rating.PASS,
	risk_count=0,
	highest_risk=None,
	)

[djstrong]

NameWrapper (Punycode) label is <=63

[lightwalker-eth]

Great ! 👍