Remove fake_eth_name_check endpoint and change fake_eth_name_check_fi… #189
Conversation
djstrong
requested review from
Byczong,
Carbon225,
kamilcieslak5100,
lightwalker-eth and
notrab
as code owners
|
This pull request has been linked to Shortcut Story #23023: Remove fake_eth_name_check endpoint and change fake_eth_name_check_fields into fake_eth_name_check. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
Overall looking good. Shared a few comments with feedback 👍
| ) | ||
|
|
||
|
|
||
| @pytest.mark.flaky(retries=2, condition=not pytest.use_monkeypatch) |
There was a problem hiding this comment.
These tests are awesome and would prefer that we not lose them. We just need to move this logic into a new example app that is a wrapper of the TypeScript SDK.
There was a problem hiding this comment.
@lightwalker-eth I have added link to these tests in the story.
…elds into fake_eth_name_check
djstrong
force-pushed
the
krzysztofwrobel/sc-23023/remove-fake-eth-name-check-endpoint-and-change
branch
from
aae6679 to
0d100a1
Compare
notrab
left a comment
notrab
left a comment
There was a problem hiding this comment.
Few comments about the documentation style for fields. I prefer this object to be passed directly instead of assigning it as a const.
Co-authored-by: Jamie Barton <jamie@notrab.dev>
Co-authored-by: Jamie Barton <jamie@notrab.dev>
Co-authored-by: Jamie Barton <jamie@notrab.dev>
…e-check-endpoint-and-change
djstrong
deleted the
krzysztofwrobel/sc-23023/remove-fake-eth-name-check-endpoint-and-change
branch
…elds into fake_eth_name_check