feat(sdk): AbortController #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notrab
requested review from
Byczong,
Carbon225,
djstrong,
kamilcieslak5100 and
lightwalker-eth
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lightwalker-eth
approved these changes
Jan 8, 2024
Member
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
@notrab cool improvements here ! Nice work 👍
| * @param {object} headers Additional headers for the request. | ||
| * @returns {Promise<any>} The response from the API. | ||
| */ | ||
| async rawRequest( |
Member
There was a problem hiding this comment.
Should we explicitly identify this as public or private?
Member
Author
There was a problem hiding this comment.
I'd prefer to keep this accessible but not documented. It's useful being public to allow us to make additional requests to the API for new endpoints without having to update or hack the SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to push this on Saturday but I was using the SDK with an input similar to what you see on nameguard.io but there was no way to abort current requests. Also includes some minimal refactoring.