Rename ens webfont font family [sc-24299] #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notrab
requested review from
Byczong,
Carbon225,
djstrong and
lightwalker-eth
as code owners
|
This pull request has been linked to Shortcut Story #24299: Rename ens-webfont font family. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
So this solves the issue when some Inter is remotely loaded by other import, right? So we should prefix all our web fonts? |
Member
Author
|
@djstrong yeah this resolves an issue if you use or load Inter in addition to this library. |
lightwalker-eth
approved these changes
Feb 19, 2024
Member
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
@notrab appreciate all the effort that went into finding this fix 👍 Thank you. Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.