Skip to content

Remove cjs #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lightwalker-eth merged 21 commits into from
May 21, 2024
Merged

Remove cjs #268

lightwalker-eth merged 21 commits into from
May 21, 2024

Conversation

@lightwalker-eth
Copy link
Member

@lightwalker-eth lightwalker-eth commented May 17, 2024

No description provided.

@vercel
Copy link

vercel bot commented May 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples.nameguard.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 5:45pm
nameguard-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 5:45pm
nameguard.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 5:45pm
storybook.namekit.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 5:45pm

@changeset-bot
Copy link

changeset-bot bot commented May 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a9e090e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – nameguard-storybook May 20, 2024 17:53 Inactive
@vercel vercel bot temporarily deployed to Preview – nameguard-storybook May 20, 2024 17:55 Inactive
@vercel vercel bot temporarily deployed to Preview – nameguard-storybook May 20, 2024 17:58 Inactive
@vercel vercel bot temporarily deployed to Preview – nameguard-storybook May 20, 2024 18:04 Inactive
lightwalker-eth
lightwalker-eth commented May 21, 2024
View reviewed changes
Copy link
Member Author

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notrab Thanks for your actions here! Have a few questions. Appreciate your advice!

lightwalker-eth
lightwalker-eth commented May 21, 2024
View reviewed changes
Copy link
Member Author

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notrab Updates look great, thank you! 🚀

@lightwalker-eth lightwalker-eth merged commit 868a4ba into main May 21, 2024
@lightwalker-eth lightwalker-eth deleted the remove-cjs branch May 21, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notrab notrab notrab approved these changes

@djstrong djstrong Awaiting requested review from djstrong djstrong is a code owner

@Carbon225 Carbon225 Awaiting requested review from Carbon225

@BanaSeba BanaSeba Awaiting requested review from BanaSeba

@edulennert edulennert Awaiting requested review from edulennert

+1 more reviewer

@FrancoAguzzi FrancoAguzzi FrancoAguzzi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lightwalker-eth @notrab @FrancoAguzzi