Notrab/sc 26147/nameai fix ux of unnormalized label submissions #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…d-label-submissions
notrab
requested review from
BanaSeba,
Carbon225,
FrancoAguzzi,
djstrong,
edulennert and
lightwalker-eth
as code owners
lightwalker-eth
approved these changes
Jan 29, 2025
Member
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
@notrab Hey good to see these enhancements. Approving this PR now to help unblock merging it in. Also shared some suggestions with feedback that are fine to action in a separate future PR 👍
| } | ||
|
|
||
| try { | ||
| const normalizedLabel = ens_normalize(label); |
Member
There was a problem hiding this comment.
We also need to check if label includes any "." characters. If it does, that should be another error case, because the input is more than 1 label.
Member
Author
There was a problem hiding this comment.
So I added this as client side validation for MVP as waiting for a network response for the validation seemed overkill for something that can be detected on the client.
| if (inputValue) { | ||
| let error = null; | ||
|
|
||
| if (inputValue.includes(" ")) { |
Member
There was a problem hiding this comment.
Suggest some refactoring such that you define just a single function in the whole app that takes as input a string (let's call it unvalidatedLabel). This function should then either return a validatedLabel that is guaranteed to not be an empty string, not to contain more than 1 label, and to be ENS normalized. If this function identifies any problems with unvalidatedLabel it should throw an exception with the appropriate error message. Callers of this function can then manage their own logic for how to take action if an exception is thrown by this function.
| return ( | ||
| <form onSubmit={handleSubmit} className="mb-6"> | ||
| <div className="flex items-start justify-center space-x-2 flex-1"> | ||
| <Input |
Member
There was a problem hiding this comment.
Perhaps there's an opportunity to define just a single "LabelInput" UI component / full "LabelInput" form and then reuse it across both of our example apps? The logic should be exactly the same. All that changes is dynamic behaviour for what happens when a valid label is submitted.
notrab
deleted the
notrab/sc-26147/nameai-fix-ux-of-unnormalized-label-submissions
branch
FrancoAguzzi
added a commit
that referenced
this pull request
Jan 30, 2025
* feat: [SC-26223] ✨ Migrate NFTAvatar to namekit-react * feat: [sc-26178] Create readme for NameAI SDK (#578) * create readme for nameai-sdk; add license * extend response example * Fix links in NameAI API readme (#579) * fix links in readme * Update README.md --------- Co-authored-by: kwrobel.eth <djstrong@gmail.com> * feat: [sc-26164] Finish Transition of alpha.namekit.io landing page to namekit.io (#563) * add ExploreNameGraphForm to Namegraph services section * Add namekit react Button to ExploreNameGraphForm * support empty input on ExploreNameGraphForm * use namekit react Input on explore-namegraph-form * improve button and text placement --------- Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com> * feat: [sc-26169] Refine namekit.io landing page (#564) * use namekit-react for X button * add Try the Alpha to mobile navigation link * avoid just 1 word wrapping to the next line on get-your-web3-name section * add "try now" button on hero section * fix button placement * fix text placement on hero section * fix screen limit * fix balancer generated layout shifts * add IconButton to mobile version of namekit.io --------- Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com> * Notrab/sc 26147/nameai fix ux of unnormalized label submissions (#575) * feat(nameai): turn off autoComplete * add data-1p-ignore * rename field * add client side validation and loading states * fix type issues * fix rank form errors * update tsconfig * fix type * sort page ux * feat: [SC-26223] ✨ Migrate NFTAvatar to namegraph.dev based on next/image dependency * feat: [SC-26223] 💄 Make NFTAvatar look shiny in the Ui * fix: [SC-26223] 🐛 Update DisplayedName to fix labels displaying for subdomains * fix: [SC-26223] 🐛 Clean unnecessary code and make it possible to switch suffixes and recharge avatars right away * fix: [SC-26223] 🐛 Fix atropos react typescript alignment * feat: [SC-26223] ✨ Remove file and optimize code syntax --------- Co-authored-by: Piotr Zawiślan <59446552+Byczong@users.noreply.github.com> Co-authored-by: kwrobel.eth <djstrong@gmail.com> Co-authored-by: Eduardo <eduramme@gmail.com> Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com> Co-authored-by: Jamie Barton <jamie@notrab.dev>
FrancoAguzzi
added a commit
that referenced
this pull request
Feb 2, 2025
…#570) * feat: [SC-26202] ✨ Build Name Details Page draft and most important features * feat: [SC-26202] ✨ Make name details page beautiful * feat: [SC-26202] ✨ Other name ideas in Name Details page * feat: [SC-26202] 🐛 Fix build errors * feat: [SC-26202] 💄 Improve visualization in Name Details page * feat: [SC-26202] ✨ Add Skeletons to Name Details page * feat: [SC-26202] ✨ Add possibility of not loading related collection from suggestionsByCategory NameGraph SDK endpoint * feat: [SC-26202] 🐛 Fix Ui bug in Collection page * fix: [SC-26202] 🐛 Align Ui type usage with API type * feat: [SC-26202] ✨ Normalizing query name input * feat: [SC-26202] ✨ Appending TLD usage from namegraph.dev in the URL * [SC-26223] ✨ Migrate NFTAvatar (#583) * feat: [SC-26223] ✨ Migrate NFTAvatar to namekit-react * feat: [sc-26178] Create readme for NameAI SDK (#578) * create readme for nameai-sdk; add license * extend response example * Fix links in NameAI API readme (#579) * fix links in readme * Update README.md --------- Co-authored-by: kwrobel.eth <djstrong@gmail.com> * feat: [sc-26164] Finish Transition of alpha.namekit.io landing page to namekit.io (#563) * add ExploreNameGraphForm to Namegraph services section * Add namekit react Button to ExploreNameGraphForm * support empty input on ExploreNameGraphForm * use namekit react Input on explore-namegraph-form * improve button and text placement --------- Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com> * feat: [sc-26169] Refine namekit.io landing page (#564) * use namekit-react for X button * add Try the Alpha to mobile navigation link * avoid just 1 word wrapping to the next line on get-your-web3-name section * add "try now" button on hero section * fix button placement * fix text placement on hero section * fix screen limit * fix balancer generated layout shifts * add IconButton to mobile version of namekit.io --------- Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com> * Notrab/sc 26147/nameai fix ux of unnormalized label submissions (#575) * feat(nameai): turn off autoComplete * add data-1p-ignore * rename field * add client side validation and loading states * fix type issues * fix rank form errors * update tsconfig * fix type * sort page ux * feat: [SC-26223] ✨ Migrate NFTAvatar to namegraph.dev based on next/image dependency * feat: [SC-26223] 💄 Make NFTAvatar look shiny in the Ui * fix: [SC-26223] 🐛 Update DisplayedName to fix labels displaying for subdomains * fix: [SC-26223] 🐛 Clean unnecessary code and make it possible to switch suffixes and recharge avatars right away * fix: [SC-26223] 🐛 Fix atropos react typescript alignment * feat: [SC-26223] ✨ Remove file and optimize code syntax --------- Co-authored-by: Piotr Zawiślan <59446552+Byczong@users.noreply.github.com> Co-authored-by: kwrobel.eth <djstrong@gmail.com> Co-authored-by: Eduardo <eduramme@gmail.com> Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com> Co-authored-by: Jamie Barton <jamie@notrab.dev> * feat: [SC-26202] ✨ Align namegraph.dev "search" URL query param to Debounced Input in collections page * feat: [SC-26202] ⚙️ Adjust query params provider in namegraph.dev * feat: [SC-26202] ⚙️ Enhance namegraph.dev URLs and code reusing --------- Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com> Co-authored-by: Piotr Zawiślan <59446552+Byczong@users.noreply.github.com> Co-authored-by: kwrobel.eth <djstrong@gmail.com> Co-authored-by: Eduardo <eduramme@gmail.com> Co-authored-by: Jamie Barton <jamie@notrab.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.