[Bugfix] Normalize File Properties #581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the file properties handling in the following ways: - Introduces `CaseInsensitiveFilePropertiesProvider` to ensure that file property keys are treated as case-insensitive. - Introduces `FreshestRevisionFilePropertiesProvider` to ensure that only the properties from the latest revision are used and cached. - Modifies `LiveSubsonicConnection` to store properties in a `HashMap` instead of a case-insensitive `TreeMap` as case-insensitivity is now handled by `CaseInsensitiveFilePropertiesProvider`.
This commit refactors the file properties system to use a `LookupFileProperties` interface instead of a `Map<String, String>`. This change provides several benefits: - **Type safety:** The interface defines specific properties like `artist`, `album`, etc. - **Lazy loading:** The implementation `FilePropertiesLookup` uses lazy loading for properties. - **Extensibility:** The interface can be extended to add new properties or functionality in the future. - **Read-only and editable properties:** The system now distinguishes between read-only and editable properties. - **Removed `CaseInsensitiveFilePropertiesProvider`:** Case-insensitivity is now handled within the `FilePropertiesLookup` implementation. - Moved helper functions and classes into the `FileProperties.kt` file. - Removed `EditableLibraryFilePropertiesProvider.kt`, `ProvideEditableLibraryFileProperties.kt`, and related tests as this functionality is now handled within `FilePropertiesLookup` and inheritors.
- Bound starting totalDistanceTraveled - Skip initial state updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.