Skip to content

Update default Node.js version to 18 #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Steve Ognibene (nycdotnet) merged 2 commits into from
Jul 25, 2023
Merged

Update default Node.js version to 18 #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e221a8
Update default Node.js version to 18
nycdotnet Jul 25, 2023
226ba34
remove unsafe perm - no longer supported this way in Node.js 18 defau…
nycdotnet Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ RUN curl -fsSL "https://deb.nodesource.com/setup_${node_version}.x" | bash -
RUN apt-get install -y nodejs

# Add Node TypeScript support
RUN npm config set unsafe-perm true
RUN npm i -g grpc_tools_node_protoc_ts@$node_grpc_tools_node_protoc_ts_version grpc-tools@$node_grpc_tools_version protoc-gen-grpc-web@$node_protoc_gen_grpc_web_version

# Add TypeScript support
Expand Down
2 changes: 1 addition & 1 deletion variables.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ PROTOBUF_JS_VERSION=${PROTOBUF_JS_VERSION:-v3.21.2}
UBER_PROTOTOOL_VERSION=${UBER_PROTOTOOL_VERSION:-1.10.0}
SCALA_PB_VERSION=${SCALA_PB_VERSION:-0.11.0}
MYPY_VERSION=${MYPY_VERSION:-3.4.0}
NODE_VERSION=${NODE_VERSION:-14}
NODE_VERSION=${NODE_VERSION:-18}
NODE_GRPC_TOOLS_NODE_PROTOC_TS_VERSION=${NODE_GRPC_TOOLS_NODE_PROTOC_TS_VERSION:-5.3.2}
NODE_GRPC_TOOLS_VERSION=${NODE_GRPC_TOOLS_VERSION:-1.12.3}
NODE_PROTOC_GEN_GRPC_WEB_VERSION=${NODE_PROTOC_GEN_GRPC_WEB_VERSION:-1.4.1}
Expand Down