Margin Type and Profit

[hidromedusa]

It would be great if the margin type could be "FIXED AMOUNT + PERCENTAGE" and not have to select only one of them.

[jas8522]

You could modify it to add that :)

See https://github.com/namesilo/whmcs/blob/master/namesilo-price-sync.php:76

You'll find:

			if (preg_match('/(%|p)/i', $margin)) {
				$marginType = 'percentage';
				
				$margin = preg_replace('/(%|p)/i', '', $margin);
			}

Add right after that:

			else if (preg_match('/(+)/i', $margin)) {
				$marginType = 'both';
			}

Then on line 1272 you'll find:

		//Add margin to price
		if ($marginType == 'fixed') {
			$newPrice += $margin;
		} elseif ($marginType == 'percentage') {
			$newPrice += $newPrice * ($margin/100);
		}

Append after it:

		elseif ($marginType == 'both') {
 			$margin_both = explode('+', $margin);
			$newPrice += ($newPrice + $margin_both[0]) * ($margin_both[1]/100);
		}

Then when you run the script set the command line parameter like the following for $2 + 15%:
-margin=2+15

Note that I have not tested this code, but it should get you most of the way there should it not work as is.

[hidromedusa]

hi.

it didn't work for me.
just add the first margin to it.

thank you.

[jas8522]

Hi @hidromedusa try this: https://github.com/websavers/WHMCS-NameSilo
If there's still issues, please create an issue under that repository for us to troubleshoot.