Skip to content

Conversation

@TheLazzziest
Copy link

Update six module related code to add django 3 support.

@TheLazzziest TheLazzziest requested review from lnagel and removed request for madisvain February 24, 2020 11:38
@lnagel
Copy link
Member

lnagel commented Feb 25, 2020

Thanks for the PR! It's great to see additional people getting involved :)
I will be reviewing this in the next few days, and then upgrading our own projects using the library to Django 3 as well. It will be a great way to validate this version.

@lnagel
Copy link
Member

lnagel commented Feb 25, 2020

@TheLazzziest I am also thinking of dropping Python 2 support entirely. Any objections?

@TheLazzziest
Copy link
Author

@lnagel , hi. None of them.

Actually, I would like to go a bit futher, and suggest to make this library on top of djoser and djangorestframework-simplejwt in order to focus on sso features only. What do you think?

@lnagel lnagel merged commit f2741bc into namespace-ee:master Apr 9, 2020
@lnagel
Copy link
Member

lnagel commented Apr 10, 2020

Thanks @TheLazzziest for the help with Django 3.0 compat. I did have to revert a few things after the merge, but nothing serious.

Regards to djoser and djangorestframework-simplejwt - maybe you could describe how that change would be useful? I don't yet see much benefit in such a change to add these dependencies.

@TheLazzziest
Copy link
Author

I did a fork of your repo, and made some sort of proof of concept. Well, It's turned out that djoser doesn't need at all. Instead, djangorestframework-simplejwt has all required stuff to make the transport layer of sso in case of using jwt. Thus, I suggest to focus on implementations of different approaches to sso for django rather then trying to encompass all at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants