Conversation
This commit addresses numerous ESLint errors reported by `npm run lint`. Key changes include: - Corrected ESLint configuration (eslint.config.js) for better module type detection, React version detection, and project references (tsconfig paths). - Resolved `no-undef` errors for `module` in CJS config files. - Addressed `'React' must be in scope` issues by adding `import React` where necessary for type usage, after confirming tsconfig's `jsx: react-jsx` was set. - Fixed unescaped entities in JSX. - Corrected `no-case-declarations` by adding blocks in switch cases. - Removed an unused variable in `use-toast.ts`. Known outstanding issues (believed to be false positives or non-critical): - Several `no-unused-vars` errors in `src/components/SortableTask.tsx` that appear to be misinterpretations by the linter. - One 'ghost' `no-unused-vars` error in `src/components/ui/use-toast.ts`. - Two `react-refresh/only-export-components` warnings (best practice, not errors). Overall, the codebase is now significantly cleaner with respect to ESLint rules.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses numerous ESLint errors reported by
npm run lint.Key changes include:
no-undeferrors formodulein CJS config files.'React' must be in scopeissues by addingimport Reactwhere necessary for type usage, after confirming tsconfig'sjsx: react-jsxwas set.no-case-declarationsby adding blocks in switch cases.use-toast.ts.Known outstanding issues (believed to be false positives or non-critical):
no-unused-varserrors insrc/components/SortableTask.tsxthat appear to be misinterpretations by the linter.no-unused-varserror insrc/components/ui/use-toast.ts.react-refresh/only-export-componentswarnings (best practice, not errors).Overall, the codebase is now significantly cleaner with respect to ESLint rules.