Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows tests for ipc #1663

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
2 participants
@cryptocode
Copy link
Collaborator

commented Jan 30, 2019

Which was actually a string lifetime issue spotted by msvc's iterator debug support.

@cryptocode cryptocode added the bug label Jan 30, 2019

@cryptocode cryptocode added this to the V18.0 milestone Jan 30, 2019

@cryptocode cryptocode self-assigned this Jan 30, 2019

@cryptocode cryptocode requested a review from wezrule Jan 30, 2019

@wezrule

This comment has been minimized.

Copy link
Collaborator

commented Jan 30, 2019

Working for me now, good job!

@cryptocode cryptocode merged commit a40cb66 into nanocurrency:master Jan 30, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@cryptocode cryptocode added this to CP 3 (2018-01-27) in V18 Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.