Check that full is not empty and assert#1753
Merged
wezrule merged 1 commit intonanocurrency:masterfrom Feb 22, 2019
Merged
Conversation
SergiySW
approved these changes
Feb 19, 2019
Contributor
SergiySW
left a comment
SergiySW
left a comment
There was a problem hiding this comment.
Seems good after v18 release
zhyatt
added
the
quality improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fullis not checked as to whether it has any elements in before popping off the container, which I guess can happen in some circumstances as the comment above the function declaration states// Return nullptr if the container has stopped. I have added an assert to check for this as well as a precaution.