Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that full is not empty and assert #1753

Merged
merged 1 commit into from Feb 22, 2019

Conversation

3 participants
@wezrule
Copy link
Collaborator

commented Feb 19, 2019

full is not checked as to whether it has any elements in before popping off the container, which I guess can happen in some circumstances as the comment above the function declaration states // Return nullptr if the container has stopped. I have added an assert to check for this as well as a precaution.

@wezrule wezrule added this to the V19.0 milestone Feb 19, 2019

@wezrule wezrule self-assigned this Feb 19, 2019

@wezrule wezrule requested a review from SergiySW Feb 19, 2019

@SergiySW
Copy link
Collaborator

left a comment

Seems good after v18 release

@zhyatt zhyatt added this to CP0 in V19 Feb 19, 2019

@wezrule wezrule merged commit a0369e3 into nanocurrency:master Feb 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:circular_buffer_full_check branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.