Skip to content

Improve CLI --wallet_import#1800

Merged
SergiySW merged 1 commit intonanocurrency:masterfrom
SergiySW:cli/wallet_import
Mar 6, 2019
Merged

Improve CLI --wallet_import#1800
SergiySW merged 1 commit intonanocurrency:masterfrom
SergiySW:cli/wallet_import

Conversation

@SergiySW
Copy link
Copy Markdown
Contributor

@SergiySW SergiySW commented Mar 3, 2019

Return error if new wallet is encrypted & provided password invalid
Full import for new wallet with --force option instead of private keys import

Return error if new wallet is encrypted & provided password invalid
Full import for new wallet with --force option instead of private keys import
@SergiySW SergiySW added the quality improvements This item indicates the need for or supplies changes that improve maintainability label Mar 3, 2019
@SergiySW SergiySW added this to the V19.0 milestone Mar 3, 2019
@SergiySW SergiySW self-assigned this Mar 3, 2019
@SergiySW SergiySW requested review from argakiig and cryptocode March 3, 2019 12:48
@SergiySW SergiySW mentioned this pull request Mar 3, 2019
@SergiySW SergiySW merged commit bd0707d into nanocurrency:master Mar 6, 2019
@zhyatt zhyatt added the documentation This item indicates the need for or supplies updated or expanded documentation label Apr 9, 2019
@zhyatt
Copy link
Copy Markdown
Collaborator

zhyatt commented Jul 10, 2019

@SergiySW Can you explain more about how the --force option functions? I don't see any documentation for it now.

@zhyatt
Copy link
Copy Markdown
Collaborator

zhyatt commented Jul 11, 2019

If the provided wallet does not exist and --force is included, a new wallet will be created with the provided wallet id value, and the json file will be imported as is with existing seed and password (instead of a set of private keys without a change of seed).

@zhyatt zhyatt removed the documentation This item indicates the need for or supplies updated or expanded documentation label Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quality improvements This item indicates the need for or supplies changes that improve maintainability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants