Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debugging assert from socket #2000

Merged
merged 1 commit into from May 21, 2019

Conversation

2 participants
@cryptocode
Copy link
Collaborator

commented May 20, 2019

Leftover from debugging, was hit during testing of the TCP live message PR. The assert should be removed - async_read will just fail with operation_aborted if the socket is closed.

@cryptocode cryptocode added this to the V19.0 milestone May 20, 2019

@cryptocode cryptocode requested a review from SergiySW May 20, 2019

@cryptocode cryptocode self-assigned this May 20, 2019

@cryptocode cryptocode added this to RC 3 (TBD) in V19 May 20, 2019

@SergiySW
Copy link
Collaborator

left a comment

LGTM

@cryptocode cryptocode merged commit dd797db into nanocurrency:master May 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:tcp-remove-assert branch May 21, 2019

argakiig added a commit to argakiig/raiblocks that referenced this pull request May 21, 2019

argakiig added a commit to argakiig/raiblocks that referenced this pull request May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.