Skip to content

Remove debugging assert from socket#2000

Merged
cryptocode merged 1 commit intonanocurrency:masterfrom
cryptocode:tcp-remove-assert
May 21, 2019
Merged

Remove debugging assert from socket#2000
cryptocode merged 1 commit intonanocurrency:masterfrom
cryptocode:tcp-remove-assert

Conversation

@cryptocode
Copy link
Copy Markdown
Contributor

@cryptocode cryptocode commented May 20, 2019

Leftover from debugging, was hit during testing of the TCP live message PR. The assert should be removed - async_read will just fail with operation_aborted if the socket is closed.

@cryptocode cryptocode added this to the V19.0 milestone May 20, 2019
@cryptocode cryptocode requested a review from SergiySW May 20, 2019 19:41
@cryptocode cryptocode self-assigned this May 20, 2019
Copy link
Copy Markdown
Contributor

@SergiySW SergiySW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cryptocode cryptocode merged commit dd797db into nanocurrency:master May 21, 2019
@cryptocode cryptocode deleted the tcp-remove-assert branch May 21, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants