Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate difficulty was passing hash by ref #2008

Merged

Conversation

@argakiig
Copy link
Collaborator

commented May 21, 2019

and could go out of scope before the callback was called
copy into lambda instead

generate difficulty was passing hash by ref
and could go out of scope before the callback was called
copy into lambda instead

@argakiig argakiig added this to the V19.0 milestone May 21, 2019

@argakiig argakiig requested review from wezrule, SergiySW and cryptocode May 21, 2019

@argakiig argakiig self-assigned this May 21, 2019

@zhyatt zhyatt added this to RC 3 (TBD) in V19 May 21, 2019

@argakiig argakiig merged commit 24734f6 into nanocurrency:master May 21, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

argakiig added a commit to argakiig/raiblocks that referenced this pull request May 21, 2019

generate difficulty was passing hash by ref (nanocurrency#2008)
and could go out of scope before the callback was called
copy into lambda instead

argakiig added a commit to argakiig/raiblocks that referenced this pull request May 22, 2019

generate difficulty was passing hash by ref (nanocurrency#2008)
and could go out of scope before the callback was called
copy into lambda instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.