Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stringstream test sink to bounds check the strings #2016

Merged
merged 1 commit into from May 22, 2019

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented May 22, 2019

@SergiySW found an ASAN warning when running the confirmation_height.conflict_rollback_cemented test. The const char * does not appear to be null terminated. Cannot use std::stringstream::read as it expects a non-const char array and would prefer not to introduce a const_cast. It's only used in tests so just going to construct a new string of the expected size.

@wezrule wezrule added this to the V19.0 milestone May 22, 2019

@wezrule wezrule requested a review from SergiySW May 22, 2019

@wezrule wezrule self-assigned this May 22, 2019

@wezrule wezrule added this to During RC in V19 May 22, 2019

@SergiySW
Copy link
Collaborator

left a comment

LGTM

@wezrule wezrule merged commit 4bf4c95 into nanocurrency:master May 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:asan_stringstream_test branch May 22, 2019

@zhyatt zhyatt moved this from During RC to RC 4 (TBD) in V19 May 27, 2019

argakiig added a commit that referenced this pull request Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.