Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable confirmation history container #2049

Merged

Conversation

@argakiig
Copy link
Collaborator

commented May 31, 2019

defaults to maintain existing behavior 2048
update tests for v17 and upgrade path
rename variable to confirmation_history_size to be more accurate

Configurable confirmation history container
defaults to maintain existing behavior 2048
update tests for v17 and upgrade path

@argakiig argakiig added this to the V19.0 milestone May 31, 2019

@argakiig argakiig self-assigned this May 31, 2019

@argakiig argakiig requested review from wezrule, cryptocode and SergiySW May 31, 2019

@zhyatt zhyatt added this to RC 4 (TBD) in V19 May 31, 2019

@argakiig argakiig added the enhancement label Jun 3, 2019

@argakiig argakiig merged commit 6860637 into nanocurrency:master Jun 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@argakiig argakiig referenced this pull request Jun 3, 2019

Merged

Update configuration.md #26

@argakiig argakiig deleted the argakiig:configurable_confirmation_container branch Jun 3, 2019

@argakiig argakiig restored the argakiig:configurable_confirmation_container branch Jun 6, 2019

@argakiig argakiig deleted the argakiig:configurable_confirmation_container branch Jun 6, 2019

@argakiig argakiig restored the argakiig:configurable_confirmation_container branch Jun 6, 2019

argakiig added a commit that referenced this pull request Jun 11, 2019

Configurable confirmation history container (#2049)
* Configurable confirmation history container
defaults to maintain existing behavior 2048
update tests for v17 and upgrade path

* rename to confirmation_history_size for readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.