Configurable confirmation history container#2049
Merged
argakiig merged 3 commits intonanocurrency:masterfrom Jun 3, 2019
argakiig:configurable_confirmation_container
Merged
Configurable confirmation history container#2049argakiig merged 3 commits intonanocurrency:masterfrom argakiig:configurable_confirmation_container
argakiig merged 3 commits intonanocurrency:masterfrom
argakiig:configurable_confirmation_container
Conversation
defaults to maintain existing behavior 2048 update tests for v17 and upgrade path
argakiig
added
the
documentation
wezrule
approved these changes
May 31, 2019
cryptocode
approved these changes
May 31, 2019
SergiySW
approved these changes
Jun 1, 2019
argakiig
pushed a commit
that referenced
this pull request
Jun 11, 2019
* Configurable confirmation history container defaults to maintain existing behavior 2048 update tests for v17 and upgrade path * rename to confirmation_history_size for readability
zhyatt
removed
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defaults to maintain existing behavior 2048
update tests for v17 and upgrade path
rename variable to confirmation_history_size to be more accurate