Skip to content

Flag to disable TCP realtime network#2103

Merged
SergiySW merged 5 commits intonanocurrency:masterfrom
SergiySW:config/disable_tcp_realtime_flag
Jun 26, 2019
Merged

Flag to disable TCP realtime network#2103
SergiySW merged 5 commits intonanocurrency:masterfrom
SergiySW:config/disable_tcp_realtime_flag

Conversation

@SergiySW
Copy link
Copy Markdown
Contributor

Similar to disabling UDP

@SergiySW SergiySW added this to the V19.0 milestone Jun 21, 2019
@SergiySW SergiySW requested review from cryptocode and wezrule June 21, 2019 20:36
@SergiySW SergiySW self-assigned this Jun 21, 2019
@wezrule
Copy link
Copy Markdown
Contributor

wezrule commented Jun 23, 2019

Is it possible to add a test for this?
Also what if a user disables both udp and tcp, perhaps this combination should be prevented (or can it be useful for testing something?)

@wezrule wezrule requested review from argakiig and removed request for wezrule June 25, 2019 17:49
@SergiySW SergiySW merged commit 2c53ab0 into nanocurrency:master Jun 26, 2019
argakiig pushed a commit that referenced this pull request Jun 27, 2019
* Flag to disable TCP realtime network
* Fix errors
* Apply changes from review & add flags tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants