Skip to content

Remove implementations of GetHashCode() from several classes#21

Merged
josesimoes merged 2 commits intonanoframework:developfrom
Eclo:replace-GetHashCode
Aug 7, 2018
Merged

Remove implementations of GetHashCode() from several classes#21
josesimoes merged 2 commits intonanoframework:developfrom
Eclo:replace-GetHashCode

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

Motivation and Context

  • There is a native function that provides the hash code for most of the classes. Despite not being the most efficient implementation it seems that is the option for now.
    🚩 for review on a future iteration.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Copy Markdown
Member

nfbot commented Aug 7, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit f80765c into nanoframework:develop Aug 7, 2018
@josesimoes josesimoes deleted the replace-GetHashCode branch August 7, 2018 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants