Constructor should copy only the desired chars#24
Merged
josesimoes merged 2 commits intonanoframework:developfrom Sep 12, 2018
Merged
Constructor should copy only the desired chars#24josesimoes merged 2 commits intonanoframework:developfrom
josesimoes merged 2 commits intonanoframework:developfrom
Conversation
If startIndex is not zero and length not value.length the last line in the constructor would throw an exception.
Member
|
Hi @MatthiasJentsch, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If startIndex is not zero and length not value.length the last line in the constructor would throw an exception.
Motivation and Context
Found that during unit testing
How Has This Been Tested?
With this change the call
StringBuilder sb = new StringBuilder("nanoFramework", 4, 5, 7)works correctly. Without this change the call throws an exception.Types of changes
Checklist:
Signed-off-by: Matthias Jentsch info@matthias-jentsch.de