Fix Assembly.GetType(string, bool) throws ArgumentException

[NemesisXB]

Description

Motivation and Context

The Assembly.GetType(string, bool) implementation was faulty, it ignored the bool argument.

• Fixes Assembly.GetType(string, bool) throws ArgumentException Home#398

How Has This Been Tested?

Tested with the following code. Original mscorlib threw exception no matter the bool value. Reached line never reached. After the fix, if bool value is false, Reached is printed to the console. With the value set to true, the exception is still thrown.

using System;
using System.Reflection;

namespace NFApp1
{
	public class Program
	{
		public static void Main()
		{
			Assembly a = Assembly.GetAssembly(typeof(Program));
			Type t = a.GetType("NotExistingType", false);

                        Console.WriteLine("Reached");
		}
	}
}

Screenshots

Types of changes

• Improvement (non-breaking change that improves a feature, code or algorithm)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

Signed-off-by: NemesisXB 485436+NemesisXB@users.noreply.github.com

[nfbot]

Hi @NemesisXB,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

[josesimoes]

LGTM