Skip to content

Fix ReadOnlySpan<T> operator == to use identity semantics#272

Merged
josesimoes merged 1 commit intonanoframework:developfrom
josesimoes:readonly-span-improvements
Apr 27, 2026
Merged

Fix ReadOnlySpan<T> operator == to use identity semantics#272
josesimoes merged 1 commit intonanoframework:developfrom
josesimoes:readonly-span-improvements

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

  • Replace element-wise content comparison with reference equality on the internal heap block, matching the .NET spec.
  • Update tests accordingly.

Motivation and Context

  • Fixes operator == for ReadOnlySpan<T>.

How Has This Been Tested?

  • Unit tests added.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

- Replace element-wise content comparison with reference equality on the internal heap block, matching the .NET spec.
- Update tests accordingly.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: nanoframework/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 26150760-30c9-4c43-b1ab-9d96a56ace74

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@josesimoes josesimoes merged commit 30df403 into nanoframework:develop Apr 27, 2026
6 checks passed
@josesimoes josesimoes deleted the readonly-span-improvements branch April 27, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants