Skip to content

Work extracting System.Math #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2018
Merged

Work extracting System.Math #51

merged 1 commit into from
Oct 25, 2018

Conversation

@josesimoes
Copy link
Member

@josesimoes josesimoes commented Oct 25, 2018

Description

  • Replace remaining System.Math methods with internal ones
  • Add friends declaration to make internals available to new system.math

Motivation and Context

  • Can't have partial classes across assemblies.
  • Need to make these MathInternal methods available to new System.Math.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Work extracting System.Math
18a3f18 
- Replace remaining System.Math methods with internal ones
- Add friends declaration to make internals available to new system.math

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Oct 25, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 825bd7e into nanoframework:develop Oct 25, 2018
@josesimoes josesimoes deleted the work-extract-system.math branch October 25, 2018 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Area: Config-and-Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@josesimoes @nfbot