Skip to content

Conversation

@josesimoes
Copy link
Member

Description

  • Fix implementation of _ticksAtOrigin.

Motivation and Context

  • Our DateTime tick values was different from the .NET implementation.
  • Bump version to 1.2.5-preview.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@nfbot
Copy link
Member

nfbot commented Jun 12, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

- Our DateTime tick values was diferent from the .NET implementation.
- Bump version to 1.2.5-preview.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes force-pushed the fix-datetime-TicksAtOrigin branch from 2ffb864 to 06c6fc8 Compare June 12, 2019 16:39
@josesimoes
Copy link
Member Author

SonarCloud Quality gate failing because of lack of tests. Accepting.

@josesimoes josesimoes merged commit 999561a into nanoframework:develop Jun 12, 2019
@josesimoes josesimoes deleted the fix-datetime-TicksAtOrigin branch June 12, 2019 16:44
@josesimoes josesimoes mentioned this pull request Jun 20, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants