Skip to content

Add NoReflection project to solution #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2020
Merged

Add NoReflection project to solution #99

merged 1 commit into from
Mar 9, 2020

Conversation

@josesimoes
Copy link
Member

@josesimoes josesimoes commented Mar 9, 2020 •
edited
Loading

Description

  • Add NoReflection project to solution.
  • Update Azure yaml to buil, package and publish a single release.

Motivation and Context

  • Need to have a single release for both flavours because of CD-CI pipeline.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@nfbot
Copy link
Member

nfbot commented Mar 9, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Add NoReflection project to solution
8349f5a 
- Add NoReflection project to solution.
- Update Azure yaml to buil, package and publish a single release.

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes force-pushed the add-project-noreflection branch from e797c3f to 8349f5a Compare March 9, 2020 13:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@josesimoes josesimoes merged commit 254eba1 into nanoframework:develop Mar 9, 2020
@josesimoes josesimoes deleted the add-project-noreflection branch March 9, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Area: Config-and-Build CI: Publish Release CI: Update Dependents

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@josesimoes @nfbot