Skip to content

Conversation

@josesimoes
Copy link
Member

Description

  • Change properties to expression body.
  • Remove ChipSelectLineCount property.
  • Minor tweaks in comments.
  • Fix code style.
  • Add ArgumentOutOfRangeException to GetBusInfo().
  • Adjust Unit Tests accordingly.
  • Bump AssemblyNativeVersion to 100.1.1.0.
  • Bump version to 1.0.4-preview.
  • Adjust README.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

- Change properties to expression body.
- Remove ChipSelectLineCount property.
- Minor tweaks in comments.
- Fix code style.
- Add ArgumentOutOfRangeException to GetBusInfo().
- Adjust Unit Tests accordingly.
- Bump AssemblyNativeVersion to 100.1.1.0.
- Bump version to 1.0.4-preview.
- Adjust README.
@nfbot nfbot added Type: enhancement New feature or request Breaking-Change Type: Documentation Improvements or additions to documentation labels Feb 24, 2022
@josesimoes josesimoes requested a review from Ellerbach February 24, 2022 15:00
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And all looks good as well on the managed side as well!

@josesimoes josesimoes merged commit da90bc1 into nanoframework:develop Feb 24, 2022
@josesimoes josesimoes deleted the work-966 branch February 24, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking-Change Type: Documentation Improvements or additions to documentation Type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants