Skip to content

Conversation

@Feiko
Copy link
Member

@Feiko Feiko commented Jan 15, 2022

Description

Option for adding custom headers to the Websockets.Client
small fix of bug when trying to close websocket that's already disposed (racing conditions) objectdisposedExpetion

Motivation and Context

You can now have extra control over custom headers. This can be used for authentication or other things. This makes the Client more usable.

How Has This Been Tested?

With websocket server and NF websocket Client.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement and great for the fix too!

@josesimoes
Copy link
Member

@Feiko don't worry about the build failure. It's with our tool. Working on it.

@Feiko
Copy link
Member Author

Feiko commented Jan 15, 2022

@josesimoes, Great! Yeah this will make the client side more use full I think.

@josesimoes josesimoes changed the title Added support for custom Http Headers for Websocket Client and fix objectdisposed expetion Added support for custom Http Headers for Websocket Jan 15, 2022
@josesimoes josesimoes enabled auto-merge (squash) January 15, 2022 12:21
@josesimoes
Copy link
Member

@Feiko something to keep in mind for future PRs: we should have these "atomic" as much as possible. Main reason to be able to isolate changes and even make quick reverts, if needed.
In this case the fix should have been on it's own PR separated from the new feature. 😉

@nfbot nfbot added Type: enhancement Type: bug Something isn't working labels Jan 15, 2022
@josesimoes josesimoes merged commit a9584eb into nanoframework:develop Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: bug Something isn't working Type: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants