Skip to content

Conversation

@josesimoes
Copy link
Member

Description

  • Rework GetSocketOption to correctly return correct type with several SocketOptionName.
  • GetSocketOption can now return value for SocketOptionName.DontLinger.
  • Rewrote some parts of the documentation to make it clearer.
  • Add some unit tests for socket options.

Motivation and Context

How Has This Been Tested?

  • Unit tests and network sample.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Rework GetSocketOption to correctly return correct type with several SocketOptionName.
- GetSocketOption can now return value for SocketOptionName.DontLinger.
- Rewrote some parts of the documentation to make it clearer.
- Add some unit tests for socket options.
@josesimoes josesimoes merged commit 77b25a3 into nanoframework:develop Jan 12, 2022
@josesimoes josesimoes deleted the improvements-socket-options branch January 12, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants