Skip to content

Adding Unit Test from .NET Microframework#25

Merged
josesimoes merged 5 commits intodevelopfrom
develop-unit-test
Mar 15, 2021
Merged

Adding Unit Test from .NET Microframework#25
josesimoes merged 5 commits intodevelopfrom
develop-unit-test

Conversation

@Ellerbach
Copy link
Copy Markdown
Member

Adding Unit Test from .NET Microframework

Description

Adding Unit Test from .NET Microframework

Motivation and Context

  • related to #704
  • Still some Decoder tests will have to be added, none were existing

How Has This Been Tested?

  • All tests run and all is green

Screenshots

image

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot added the Type: enhancement New feature or request label Mar 13, 2021
@Ellerbach
Copy link
Copy Markdown
Member Author

Note: SonarCloud adjusted to avoid security anyalize on Tests/**

Copy link
Copy Markdown
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice, our next class lib with unit tests after mscorlib.

@josesimoes josesimoes merged commit 20200d5 into develop Mar 15, 2021
@josesimoes josesimoes deleted the develop-unit-test branch March 15, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants