-
-
Notifications
You must be signed in to change notification settings - Fork 9
Add Syslog ILogger provider #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ellerbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice all up! Some adjustments needed in the code, missing headers as well, all up, real good!
Ellerbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks again. If you can adjust the few 'picky' things, it would be perfect.
|
@josesimoes the check for the versions does not understand the |
Done ;-) |
@Ellerbach it does. The thing is that, despite being a valid nuspec value, the nuspec parser doesn't deal properly with these situations. A matter of adding this new assembly to the edge case list on nanovc. |
Done :-) In PR :-) Will be a good test to see if all is in order now ;-) |
|
I saw a difference in the project file between syslog project and other projects. Crossing fingers. |
I see I'm missing the version of the packages in the nfproj project also. How can I add them ? |
@oblaise no need to worry with that. But if you want to add these, just copy from one of the other nfprojs that has them. |
So I don't see what I can do more to have the version test to pass. |
|
@oblaise please do not worry about the error in the nanovc check. |
|
@oblaise build is 🟢 !! |
|
I've fixed the package.config for you and pushed it to your working branch. |
- General improvements in comments. - Rename some parameters for clarity. - Add links in comments. - Fix syslog names and typos for coherency. - Wrap parameters. - Fix formatting and code style.
|
@oblaise did one last pass with a few more improvements. Please review and comment back if you find anything wrong and/or misplaced. |
oblaise
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me.
Give me a few minutes I will insert the comments in Facility/Severity.
@josesimoes how can I push your latest commit to my repo ? |
josesimoes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now!!
|
@oblaise thank you again for your contribution! 🙏😄 .NET nanoFramework it's all about community involvement and no contribution is too small. Please edit it and add an entry with your GitHub user in the appropriate location (names sorted alphabetically): (feel free to adjust your name, if it's not correct) |
Description
This PR add support for a Logging provider that sends logs using Syslog protocol
Motivation and Context
Syslog is a common logging provider with server present on most Un*x distributions. Servers also exist for Windows.
How Has This Been Tested?
Used in a project. Logs are sent to a Syslog server present in an opensource project: https://github.com/PJO2/tftpd64/
It is hard to create unit test as you need a server on the other side.
Types of changes
Checklist: