Skip to content

Conversation

@demichiel
Copy link
Contributor

The LuminosityPercentage stayed at 0 when initializing the screen on M5StickC Plus.

Description

I couldn't get my display working so debugged it to the setter of the Screen.LuminosityPercentage. This PR changes the type to an int and updates the setter.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

The LuminosityPercentage stayed at 0 when initializing the screen.
@nfbot nfbot added the Type: bug Something isn't working label Nov 9, 2021
@dnfadmin
Copy link

dnfadmin commented Nov 9, 2021

CLA assistant check
All CLA requirements met.

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix!

@Ellerbach Ellerbach merged commit a6de17e into nanoframework:develop Nov 9, 2021
@nfbot
Copy link
Member

nfbot commented Nov 9, 2021

@demichiel thank you again for your contribution! 🙏😄

.NET nanoFramework it's all about community involvement and no contribution is too small.
We would like to invite you to join the project Contributors list.

Please edit it and add an entry with your GitHub user in the appropriate location (names sorted alphabetically):

  <tr>
    <td><img src="https://github.com/demichiel.png?size=50&" height="50" width="50" ></td>
    <td><a href="https://github.com/demichiel"></a></td>
  </tr>

(feel free to adjust your name, if it's not correct)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants