Skip to content

Change type of LuminosityPercentage to int from byte #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Change type of LuminosityPercentage to int from byte #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions nanoFramework.M5StickCommon/Screen.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class Screen : ScreenBase
private const int DataCommand = 23;
private const int Reset = 18;
private static Axp192 _power;
private static byte _lumi;
private static int _lumi;
private static bool _isInitialized = false;

/// <summary>
Expand Down Expand Up @@ -53,7 +53,7 @@ public Screen()
/// <summary>
/// Enables or disables the screen.
/// </summary>
public static new bool Enabled
public new static bool Enabled
{
get => IsEnabled;

Expand All @@ -68,16 +68,16 @@ public Screen()
/// Sets or gets the screen luminosity.
/// </summary>
/// <remarks> On M5Stick, anything less than 20% will be fully black</remarks>
public static new byte LuminosityPercentage
public new static int LuminosityPercentage
{
get => _lumi;

set
{
// For M5Stick, values from 8 to 12 are working fine
// 2.5 V = dark, 3.0 V full luminosity
_lumi = (byte)(value > 100 ? 100 : _lumi);
_power.LDO3OutputVoltage = ElectricPotential.FromVolts((byte)(_lumi * 0.5 / 100.0 + 2.5));
_lumi = value > 100 ? 100 : value;
_power.LDO3OutputVoltage = ElectricPotential.FromVolts(_lumi * 0.5 / 100.0 + 2.5);
}
}
}
Expand Down