-
-
Notifications
You must be signed in to change notification settings - Fork 24
Fix comments for Intellisense #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add missing xml documentation.
|
Related to nanoframework/nanoframework.github.io#139 |
Ellerbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We definitely should add the linter on more repositories!
josesimoes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always better to have the Intellisense comets there.
To me, the thing with the ones here, is that they do not explain anything to the developer using them. They're are just repeating the name of the method... the warning will go away, sure, but nothing will become clearer by providing these...
|
I guess this is a comprimise. Either way, let me know whether this can be merged so we can move on. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@networkfusion this PR has conflict now. Either resolves them, either close the PR and reopen it. I was even thinking to add the linter on it. That would force to clean the comments as well. |
|
Kudos, SonarCloud Quality Gate passed!
|
Ellerbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that looks all good as well.








Description
Motivation and Context
<Content Include="packages.lock.json" />How Has This Been Tested?
Screenshots
Types of changes
Checklist: