Add method to return MIME-type given a file name #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josesimoes
added a commit
to josesimoes/nanoFramework.WebServer
that referenced
this pull request
Nov 2, 2020
- Requires nanoframework#6 to be merged.
josesimoes
force-pushed
the
add-content-type
branch
from
a6c2e11 to
1f700a4
Compare
josesimoes
added a commit
to josesimoes/nanoFramework.WebServer
that referenced
this pull request
Nov 2, 2020
- Add icon as resource (mind that editing a resource file is NOT working in VS2019). - Add processing for sending favicon (requires previous merge of nanoframework#6).
Merged
Ellerbach
approved these changes
Nov 3, 2020
Member
Ellerbach
left a comment
Ellerbach
left a comment
There was a problem hiding this comment.
Thanks, good addition, I see other PR, I'll go thru as well. Btw, the list of types is not exhaustive, that just give an idea how to manage this. So if anyone wants more, it's fairly easy to add. Also part of the plan is to add a default parameter where you can specify the type.
Ellerbach
added a commit
that referenced
this pull request
Nov 3, 2020
* Add method to return MIME-type given a file name * Add method to send file content from byte array - Requires #6 to be merged. Co-authored-by: Laurent Ellerbach <laurent@ellerbach.net>
Ellerbach
pushed a commit
that referenced
this pull request
Nov 3, 2020
* Add method to return MIME-type given a file name * Add favicon to webserver sample - Add icon as resource (mind that editing a resource file is NOT working in VS2019). - Add processing for sending favicon (requires previous merge of #6).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.