Skip to content

Add favicon #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2020
Merged

Add favicon #9

merged 2 commits into from
Nov 3, 2020

Conversation

@josesimoes
Copy link
Member

@josesimoes josesimoes commented Nov 2, 2020

@josesimoes
Add method to return MIME-type given a file name
a6c2e11
@josesimoes
Add favicon to webserver sample
27eef7a 
- Add icon as resource (mind that editing a resource file is NOT working in VS2019).
- Add processing for sending favicon (requires previous merge of nanoframework#6).
@Ellerbach Ellerbach merged commit 8c81ad8 into nanoframework:master Nov 3, 2020
@Ellerbach
Copy link
Member

Ellerbach commented Nov 3, 2020

  • Add icon as resource (mind that editing a resource file is NOT working in VS2019).

So what is the way to get it compiling and working?
I get this error: nanoFramework GenerateNanoResourceTask error: Bitmap imageFormat not supported 'b96b3cb5-0728-11d3-9d7b-0000f81ef32e'

@josesimoes josesimoes deleted the add-favicon branch November 6, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ellerbach Ellerbach Ellerbach approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@josesimoes @Ellerbach