Skip to content

Fix wrong device description after enumeration#104

Merged
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:fix-device-description
Dec 7, 2017
Merged

Fix wrong device description after enumeration#104
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:fix-device-description

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

  • Improve adding devices after enumeration is completed

Motivation and Context

  • After device enumeration was completed any new device arriving would have it's description truncated because the property changed event for the collection was fired before the description was actually updated leading to a truncated description on bound controls (such as VS extension)

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Copy Markdown
Member

nfbot commented Dec 7, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 93cb3bb into nanoframework:develop Dec 7, 2017
@josesimoes josesimoes deleted the fix-device-description branch December 7, 2017 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants