Skip to content

Improvements on deployment#149

Merged
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:improvements-deployment
Jun 11, 2018
Merged

Improvements on deployment#149
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:improvements-deployment

Conversation

@josesimoes
Copy link
Copy Markdown
Member

@josesimoes josesimoes commented Jun 11, 2018 •
edited
Loading

Description

  • Improve the checks on connect async to make sure that device capabilities are always reported back from device, otherwise can't proceed
  • Add check for proper reply from device on DiscoveryInteropNativeAssemblies, failure is not an option

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Improvements on deployment
7b2094c 
- Improve the checks on connect async to make sure that device capabilities are always reported back from device, otherwise can't proceed
- Add check for proper reply from device on DiscoveryInteropNativeAssemblies, failure is not an option

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Copy Markdown
Member

nfbot commented Jun 11, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 64c7245 into nanoframework:develop Jun 11, 2018
@josesimoes josesimoes deleted the improvements-deployment branch June 11, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Type: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@josesimoes @nfbot